feat: rename VectorSearchGlobalIndexResult to ScoredGlobalIndexResult#124
Merged
lxy-9602 merged 3 commits intoFeb 9, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR primarily renames the vector-search result type to a more generic scored-result abstraction and propagates that rename through Lumina/Lucene global-index code and tests, while also extending the GlobalIndexReader interface to support full-text search results (Lucene).
Changes:
- Rename
VectorSearchGlobalIndexResult→ScoredGlobalIndexResult(andBitmapVectorSearchGlobalIndexResult→BitmapScoredGlobalIndexResult) across core logic and tests. - Add
VisitFullTextSearchtoGlobalIndexReaderand implement it for Lucene (plus placeholder implementations for other readers). - Update Lucene third-party build/linking to use a static library and add an integration test that validates scored full-text search output.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/inte/global_index_test.cpp | Updates vector-search result naming; adds a Lucene full-text search + score integration test. |
| src/paimon/global_index/lumina/lumina_global_index_test.cpp | Updates Lumina tests to use scored-result types. |
| src/paimon/global_index/lumina/lumina_global_index.h | Updates VisitVectorSearch return type; adds VisitFullTextSearch override. |
| src/paimon/global_index/lumina/lumina_global_index.cpp | Emits BitmapScoredGlobalIndexResult from Lumina vector search. |
| src/paimon/global_index/lucene/lucene_global_index_writer.h | Makes FlushIndexToFinal() non-const. |
| src/paimon/global_index/lucene/lucene_global_index_writer.cpp | Implements non-const FlushIndexToFinal(). |
| src/paimon/global_index/lucene/lucene_global_index_test.cpp | Updates Lucene tests for scored-result type changes. |
| src/paimon/global_index/lucene/lucene_global_index_reader.h | Updates vector-search result type; marks VisitFullTextSearch as override. |
| src/paimon/global_index/lucene/lucene_global_index_reader.cpp | Returns BitmapScoredGlobalIndexResult for limited full-text search. |
| src/paimon/global_index/lucene/jieba_analyzer.h | Passes shared_ptr<Jieba> by const reference. |
| src/paimon/global_index/lucene/jieba_analyzer.cpp | Matches constructor signature change. |
| src/paimon/core/table/source/data_evolution_batch_scan.cpp | Switches iterator extraction to ScoredGlobalIndexResult::ScoredIterator. |
| src/paimon/core/global_index/global_index_evaluator_impl.cpp | Renames local variables for scored results. |
| src/paimon/common/global_index/wrap/file_index_reader_wrapper.h | Updates vector-search result type; adds VisitFullTextSearch override. |
| src/paimon/common/global_index/global_index_result_test.cpp | Updates tests and expected error strings for new type names. |
| src/paimon/common/global_index/global_index_result.cpp | Serializes/deserializes BitmapScoredGlobalIndexResult instead of the old type. |
| src/paimon/common/global_index/bitmap_scored_global_index_result_test.cpp | Renames/updates unit tests for scored bitmap result. |
| src/paimon/common/global_index/bitmap_scored_global_index_result.cpp | Implements renamed scored bitmap result methods/iterators. |
| src/paimon/CMakeLists.txt | Updates source/test file lists for renamed scored-result implementation. |
| include/paimon/global_index/global_index_result.h | Introduces ScoredGlobalIndexResult and its iterator; updates docs. |
| include/paimon/global_index/global_index_reader.h | Updates vector-search return type; adds VisitFullTextSearch pure virtual. |
| include/paimon/global_index/bitmap_scored_global_index_result.h | Public header for BitmapScoredGlobalIndexResult and its iterator. |
| cmake_modules/ThirdpartyToolchain.cmake | Switches Lucene++ linkage to static (.a) and updates imported target setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
rename VectorSearchGlobalIndexResult to ScoredGlobalIndexResult
Linked issue: #69
Tests
GlobalIndexTest
API and Format
Add
VisitFullTextSearch()forGlobalIndexReader.